And please put the other fix in a separate PR, or at least commit.

Hi @pedrobaeza thanks for your comments, I moved fix on assign chart_template to #5166.
Regarding the complex code, I believe it is worth it for a few reasons :

• this is what Odoo core is trying to achieve when updating chart of account (https://github.com/odoo/odoo/blob/7df78a28dd7c05b1ea246e9f0735d8da0cb5486e/addons/account/models/chart_template.py#L257-L284), with an additional fallback to first not yet used journal of correct type
• for type = "general", you get at least 3 journals (Miscellaneous Operations, Exchange Difference, Cash Basis Taxes) + 1 extra if stock_account is installed (Inventory Valuation) - for this specific case, I believe it is better to try to find the correct one instead of assigning them randomly, falling back to assigning in order if you get no match on code / name.

@remi-filament I still think it should be simplified, as all that code Odoo core is if not XML-ID is found, but here we want to just assign one for not triggering that code, so it's enough assigning one journal, not matter which.

Fine @pedrobaeza, I was afraid that maybe somewhere in the code Odoo is trying to get account_journal by XML-id and would fail if we set the incorrect one, but maybe it does not happen.
I simplified the code to assign first of correct type instead !

Let me know if this is OK for you ?